Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop io/utils package. #1188

Merged
merged 1 commit into from
Apr 15, 2024
Merged

drop io/utils package. #1188

merged 1 commit into from
Apr 15, 2024

Conversation

zhanluxianshen
Copy link
Contributor

/kind cleanup

Drop ioutil package.
As it is deprecation , and can be replaced well.

Deprecated: As of Go 1.16, the same functionality is now 
provided by package [io](https://pkg.go.dev/io) 
or package [os](https://pkg.go.dev/os), 
and those implementations should be preferred in new code

drop io/utils package.
dbc12df 
Signed-off-by: zhanluxianshen <irelandabby883@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Apr 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov Codecov
Copy link

codecov bot commented Apr 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (1c5f633) to head (dbc12df).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1188   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          31       31           
  Lines        2851     2851           
=======================================
  Hits         2815     2815           
  Misses         29       29           
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-hang r-hang merged commit 9814dd3 into uber-go:master Apr 15, 2024
12 checks passed
@zhanluxianshen
Copy link
Contributor Author

thanks

@zhanluxianshen zhanluxianshen deleted the drop-ioutil branch April 15, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-hang r-hang r-hang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhanluxianshen @CLAassistant @r-hang